Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Information about the current view #62

Merged
merged 8 commits into from
Jul 17, 2024
Merged

Information about the current view #62

merged 8 commits into from
Jul 17, 2024

Conversation

brauliorivas
Copy link
Member

@brauliorivas brauliorivas commented Jul 14, 2024 •
edited
Loading

based on #61
BEGINRELEASENOTES

  • According to Dynamic section in the info modal #54, every view should have information about it. Explain how the relations work, what colors mean, etc. So now, if a user opens the information modal, may switch to the view section, and learn more.

ENDRELEASENOTES
Right now, it is shown simple information about the view. We can explain more about each view, so its more useful.

@brauliorivas brauliorivas linked an issue Jul 14, 2024 that may be closed by this pull request
Dynamic section in the info modal #54
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 14, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-07-17 15:28 UTC

tmadlener
tmadlener reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. One thing I would do is to make the This View the default and make About eede the thing to get to via a click. Simply because information about the view is more "useful" than about the viewer in general.

js/views/views-dictionary.js Outdated
Comment on lines 28 to 29
description:
"Red relations mean parent relation (from bottom to top), green relations mean daughter relation (from top to bottom).",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do html in the description for styling?

@kjvbrt
Copy link
Collaborator

kjvbrt commented Jul 17, 2024

Can the button for switching of the view information be hidden when the view is not used? I mean whn the user is at the intro modal.

@kjvbrt
Copy link
Collaborator

kjvbrt commented Jul 17, 2024

Also, whoudl it be possible to not have "This view", but the name of the view?

tmadlener
tmadlener reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@tmadlener tmadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result looks good to me. It's a bit hard to check with the example file that we have for full CLD simulation because at least for me some of the views take quite long to load. But I see you have already started to investigate in #63

@tmadlener
Copy link
Contributor

Also, whoudl it be possible to not have "This view", but the name of the view?

Oh yes, that would be perfect and even better than my "This view" suggestion.

@kjvbrt
Copy link
Collaborator

kjvbrt commented Jul 17, 2024

This looks "good to go" for me :)

@brauliorivas brauliorivas changed the base branch from feat/empty-view-alert to main July 17, 2024 15:26
@brauliorivas brauliorivas merged commit 2659b8f into main Jul 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmadlener tmadlener tmadlener left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamic section in the info modal
3 participants
@brauliorivas @kjvbrt @tmadlener